[
https://issues.apache.org/jira/browse/HIVE-5460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788205#comment-13788205
]
Brock Noland commented on HIVE-5460:
------------------------------------
That test is flaky as the day is long. This LGTM. +1
Also the indents on some of that existing code was very strange.
> invalid offsets in lag lead should return an exception (per ISO-SQL)
> ---------------------------------------------------------------------
>
> Key: HIVE-5460
> URL: https://issues.apache.org/jira/browse/HIVE-5460
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.11.0
> Reporter: N Campbell
> Assignee: Edward Capriolo
> Priority: Minor
> Attachments: HIVE-5460.1.patch.txt
>
>
> ISO-SQL 2011 defines how lag and lead should behave when invalid offsets are
> provided to the functions.
> i.e. select tint.rnum,tint.cint, lag( tint.cint, -100 ) over ( order by
> tint.rnum) from tint tint
> Instead of a meaningful error (as other vendors will emit) you get
> Error: Query returned non-zero code: 2, cause: FAILED: Execution Error,
> return code 2 from org.apache.hadoop.hive.ql.exec.MapRedTask
> SQLState: 08S01
> ErrorCode: 2
--
This message was sent by Atlassian JIRA
(v6.1#6144)
