[
https://issues.apache.org/jira/browse/HIVE-5556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796320#comment-13796320
]
Brock Noland commented on HIVE-5556:
------------------------------------
I have no issue with a q file test in addition to unit tests but the method you
created applyEqualityPredicateToQBJoinTree is a perfect candidate for unit
testing. WIthout a ridiculous number of queries there is no way we can say that
method is well tested. I looked at the code it's replacing a long while back
and thought "Oh man this should really be unit tested" which is why I commented
here in the first place.
> Pushdown join conditions
> ------------------------
>
> Key: HIVE-5556
> URL: https://issues.apache.org/jira/browse/HIVE-5556
> Project: Hive
> Issue Type: Sub-task
> Components: Query Processor
> Reporter: Harish Butani
> Assignee: Harish Butani
> Attachments: HIVE-5556.1.patch
>
>
> See details in HIVE-5555
--
This message was sent by Atlassian JIRA
(v6.1#6144)
