[ 
https://issues.apache.org/jira/browse/HIVE-5430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802448#comment-13802448
 ] 

Eric Hanson commented on HIVE-5430:
-----------------------------------

+1

Nice work!

I reviewed the code and made a bunch of comments, all fairly minor. You can 
come back with a second small patch to address the comments. There's no need to 
hold this patch back.

> Refactor VectorizationContext and handle NOT expression with nulls.
> -------------------------------------------------------------------
>
>                 Key: HIVE-5430
>                 URL: https://issues.apache.org/jira/browse/HIVE-5430
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>         Attachments: HIVE-5430.1.patch, HIVE-5430.2.patch, HIVE-5430.3.patch, 
> HIVE-5430.4.patch, HIVE-5430.5.patch, HIVE-5430.6.patch
>
>
> NOT expression doesn't handle nulls correctly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to