[
https://issues.apache.org/jira/browse/HIVE-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806815#comment-13806815
]
Gopal V commented on HIVE-5663:
-------------------------------
Ah, okay. I was just following the original code pattern, which had code like
{code}
private byte[] compressed = null;
{code}
which was being replaced with the ByteBuffer.
I can amend that, but it made my diffs look "same-ish" when I was viewing it
side-by-side with the current patch.
> Refactor ORC RecordReader to operate on direct & wrapped ByteBuffers
> --------------------------------------------------------------------
>
> Key: HIVE-5663
> URL: https://issues.apache.org/jira/browse/HIVE-5663
> Project: Hive
> Issue Type: Improvement
> Components: File Formats
> Affects Versions: 0.13.0
> Environment: Ubuntu LXC
> Reporter: Gopal V
> Assignee: Gopal V
> Labels: ORC
> Attachments: HIVE-5663.01.patch
>
>
> The current ORC RecordReader implementation assumes array structures backing
> the ByteBuffers it passes around between RecordReaderImpl and
> Compressed/Uncompressed InStream objects.
> This patch attempts to refactor those assumptions out of both classes,
> allowing the future use of direct byte buffers within ORC (as might come from
> HDFS zero-copy readers).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
