[ 
https://issues.apache.org/jira/browse/HIVE-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811366#comment-13811366
 ] 

Brock Noland commented on HIVE-5723:
------------------------------------

Thank you for doing this! Two questions below:

1) Don't we have to include transitive dependencies? For example if we depend 
on jar x and jar x depends on y then jar y should be required at runtime, no?

2) I haven't seen this plugin configured like this so please bear with me... I 
thought we wanted to use the copy-dependencies goal as the top example:
http://maven.apache.org/plugins/maven-dependency-plugin/examples/copying-project-dependencies.html
maybe not?

3) Should we add the lib directory to the "clean" goal?

https://github.com/apache/hive/blob/trunk/pom.xml#L311



> Add dependency plugin
> ---------------------
>
>                 Key: HIVE-5723
>                 URL: https://issues.apache.org/jira/browse/HIVE-5723
>             Project: Hive
>          Issue Type: Improvement
>          Components: Build Infrastructure
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-5723.1.patch.txt
>
>
> NO PRECOMMIT TESTS
> For easy gathering of required libraries.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to