----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14719/#review28320 -----------------------------------------------------------
Nice work!! just noting there is some lint issues with whitespace. conf/hive-default.xml.template <https://reviews.apache.org/r/14719/#comment55134> trailing whitespace needs to be removed. service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java <https://reviews.apache.org/r/14719/#comment55133> this whitespace needs to be cleaned up. Notice the bright red. service/src/java/org/apache/hive/service/cli/session/SessionManager.java <https://reviews.apache.org/r/14719/#comment55136> understand that this is not your whitepsace but since you'll be cleaning up other instances, please clean this one up too - Brock Noland On Nov. 6, 2013, 9:46 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14719/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2013, 9:46 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-5229 > https://issues.apache.org/jira/browse/HIVE-5229 > > > Repository: hive-git > > > Description > ------- > > Improves the current strategy by not keeping all the async threads alive when > there are no corresponding requests. The async threads terminate after a > configurable keepalive time if there are no new requests to handle. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fb3570b > conf/hive-default.xml.template b7234b4 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > f6adf92 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > f392d62 > > Diff: https://reviews.apache.org/r/14719/diff/ > > > Testing > ------- > > TestEmbeddedThriftBinaryCLIService, TestThriftBinaryCLIService, > TestJdbcDriver2 > > > Thanks, > > Vaibhav Gumashta > >
