----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14919/#review28325 -----------------------------------------------------------
Ship it! +1 pending tests - Brock Noland On Nov. 6, 2013, 9:03 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14919/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2013, 9:03 p.m.) > > > Review request for hive and Brock Noland. > > > Bugs: HIVE-5351 > https://issues.apache.org/jira/browse/HIVE-5351 > > > Repository: hive-git > > > Description > ------- > > Add support for encrypted communication for Plain SASL for binary thrift > transport. > - Optional thrift SSL transport on server side if configured. > - Optional thrift SSL transport for JDBC client with configurable trust store > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6dadd9c > data/files/keystore.jks PRE-CREATION > data/files/truststore.jks PRE-CREATION > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > PRE-CREATION > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestSSL.java > PRE-CREATION > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/AbstarctHiveService.java > PRE-CREATION > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java > PRE-CREATION > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2.java > PRE-CREATION > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 5a6ce44 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 02530b0 > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 5a66a6c > > service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java > 9c8f5c1 > shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java > 623ebcd > > shims/common-secure/src/main/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java > fd274a6 > > Diff: https://reviews.apache.org/r/14919/diff/ > > > Testing > ------- > > - Added a miniHS2 class that to manage thrift hiveserver2 for testing > - Basic HiveServer2 test cases with miniHS2 > - Added multiple test cases for SSL transport > > > Thanks, > > Prasad Mujumdar > >
