> On Nov. 7, 2013, 1:04 a.m., Brock Noland wrote: > > +1 pending tests
Note a huge deal but in the future could you place the JIRA (HIVE-5765) in the "Bugs" field so it's clickable back to the jira? Thx! - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15294/#review28343 ----------------------------------------------------------- On Nov. 7, 2013, 1:02 a.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15294/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 1:02 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > When running Beeline with -e option to pass in sql commands, a null pointer > exception is thrown, even though the command completes successfully. > > Beeline command execution has some pre-execution logic to get the rest > multi-line command using the consoleReader. However, there is no > console-reader available when beeline is initializing and running the command > passed in -e. Therefore, we would want to skip the multi-line logic, that is > not applicable for commands passed in with -e flag. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/Commands.java 91ee3b3 > > Diff: https://reviews.apache.org/r/15294/diff/ > > > Testing > ------- > > Manually tested, and ran TestBeelineWithArgs. > > > Thanks, > > Szehon Ho > >
