> On Nov. 7, 2013, 12:50 a.m., Thejas Nair wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java, line 233
> > <https://reviews.apache.org/r/15295/diff/1/?file=380255#file380255line233>
> >
> >     It seems like we need the delegation token only if 
> > HiveConf.ConfVars.HIVE_SERVER2_ENABLE_DOAS is true.
> >     So should we keep that condition as well ?
> >

@Thejas, Thanks for taking a look.
I am seeing that the token is required for non-impersonation case well with 
Hadoop 2.1x. Basically if the there's no TGT in ticket cache, then the child 
JVM needs either to relogin or receive token from parent. Hence the patch is 
only checking if the login is from keytab. I am still trying to find what cause 
this behavior change for hadoop.
In case of Ooize, a token is passed to hive action by Oozie and hence it 
doesn't need (and can't create) a new token.


- Prasad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15295/#review28340
-----------------------------------------------------------


On Nov. 7, 2013, 12:15 a.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15295/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 12:15 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5618
>     https://issues.apache.org/jira/browse/HIVE-5618
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> The patch is to pass the delegation token to child JVM if the parent is using 
> a keytab based login.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 540a9a1 
>   shims/0.20/src/main/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 
> 623ebcd 
>   
> shims/common-secure/src/main/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java
>  fd274a6 
>   shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 
> 62ff878 
> 
> Diff: https://reviews.apache.org/r/15295/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on secure cluster.
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>

Reply via email to