> On Nov. 9, 2013, 6:44 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java, line > > 67 > > <https://reviews.apache.org/r/15213/diff/3/?file=378196#file378196line67> > > > > Shouldn't the outputOI be writableDateOI ?
I tried to use the same that was used in original UDFDate. It used Text as return. > On Nov. 9, 2013, 6:44 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java, line > > 72 > > <https://reviews.apache.org/r/15213/diff/3/?file=378196#file378196line72> > > > > First argument should be argumentOI. Done > On Nov. 9, 2013, 6:44 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java, line > > 80 > > <https://reviews.apache.org/r/15213/diff/3/?file=378196#file378196line80> > > > > First argument should be argumentOI. Done > On Nov. 9, 2013, 6:44 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java, line > > 99 > > <https://reviews.apache.org/r/15213/diff/3/?file=378196#file378196line99> > > > > Instead of throwing up in parse exception, we should return null in > > such cases. Done > On Nov. 9, 2013, 6:44 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java, > > line 93 > > <https://reviews.apache.org/r/15213/diff/3/?file=378197#file378197line93> > > > > outputOI should be writableDateOI Same as above. followed the same used in UDFDate that returns Text. > On Nov. 9, 2013, 6:44 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java, > > line 97 > > <https://reviews.apache.org/r/15213/diff/3/?file=378197#file378197line97> > > > > First arg should be ((PrimitiveObjectInspector) arguments[0]) Done > On Nov. 9, 2013, 6:44 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java, > > line 137 > > <https://reviews.apache.org/r/15213/diff/3/?file=378197#file378197line137> > > > > Instead of throwing exception, this should return null. Done > On Nov. 9, 2013, 6:44 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java, > > line 91 > > <https://reviews.apache.org/r/15213/diff/3/?file=378198#file378198line91> > > > > In evaluate() you are creating new IntWritable everytime, instead that > > function should return int and you should do output.set() and return > > output. This way we will save unnecessary object creation of intWritable > > for each invocation. Done > On Nov. 9, 2013, 6:44 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java, > > line 97 > > <https://reviews.apache.org/r/15213/diff/3/?file=378199#file378199line97> > > > > first argument should be ((PrimitiveObjectInspector) arguments[0]) Done > On Nov. 9, 2013, 6:44 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java, > > line 137 > > <https://reviews.apache.org/r/15213/diff/3/?file=378199#file378199line137> > > > > this should return null, instead of throwing exception. Done - Mohammad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15213/#review28624 ----------------------------------------------------------- On Nov. 11, 2013, 9:03 p.m., Mohammad Islam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15213/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2013, 9:03 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5731 > https://issues.apache.org/jira/browse/HIVE-5731 > > > Repository: hive-git > > > Description > ------- > > GenericUDF class is the latest and recommended base class for any UDFs. > This JIRA is to change the current UDFDate* classes extended from GenericUDF. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 8d3a84f > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDate.java 3df453c > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateAdd.java b1b0bf2 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java da14c4f > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateSub.java c8a1d1f > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDate.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateAdd.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateDiff.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateSub.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFDateAdd.java f0af069 > ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFDateDiff.java 8a6dbc3 > ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFDateSub.java fa722a9 > ql/src/test/results/clientpositive/udf_to_date.q.out 6ff5ee8 > > Diff: https://reviews.apache.org/r/15213/diff/ > > > Testing > ------- > > > Thanks, > > Mohammad Islam > >
