----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15435/#review28749 -----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java <https://reviews.apache.org/r/15435/#comment55768> Should probably use a long and HiveConf.getLongVar instead of ints. service/src/test/org/apache/hive/service/cli/CLIServiceTest.java <https://reviews.apache.org/r/15435/#comment55770> Please try to avoid using concrete collection types on the LHS or assignments or in method parameter lists, i.e. use Map<String, String> instead of HashMap<String, String>. service/src/test/org/apache/hive/service/cli/CLIServiceTest.java <https://reviews.apache.org/r/15435/#comment55742> Please remove TABs service/src/test/org/apache/hive/service/cli/CLIServiceTest.java <https://reviews.apache.org/r/15435/#comment55767> Replace "hive.server2.long.polling.timeout" with HiveConf.ConfVars.HIVE_SERVER2_LONG_POLLING_TIMEOUT.varname. service/src/test/org/apache/hive/service/cli/CLIServiceTest.java <https://reviews.apache.org/r/15435/#comment55764> Please use a switch statement here. service/src/test/org/apache/hive/service/cli/CLIServiceTest.java <https://reviews.apache.org/r/15435/#comment55769> Formatting. - Carl Steinbach On Nov. 12, 2013, 2:16 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15435/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2013, 2:16 a.m.) > > > Review request for hive, Carl Steinbach and Thejas Nair. > > > Bugs: HIVE-5217 > https://issues.apache.org/jira/browse/HIVE-5217 > > > Repository: hive-git > > > Description > ------- > > Add long polling to asynchronous execution in HiveServer2 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 4f32390 > conf/hive-default.xml.template fe7141e > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 4ee1b74 > service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a > > Diff: https://reviews.apache.org/r/15435/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
