----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review28855 -----------------------------------------------------------
conf/hive-default.xml.template <https://reviews.apache.org/r/15449/#comment55914> "Should be a positive value" sounds like 0 will result in an error. I think it will be better to rephrase this as "Timeout is applicable only if the value is positive" service/src/java/org/apache/hive/service/cli/operation/Operation.java <https://reviews.apache.org/r/15449/#comment55913> I am not sure if we need an operation level timeout, I think the Session timeout will suffice for most use cases. But since this can be disabled through config value, I think it is OK. service/src/java/org/apache/hive/service/cli/session/SessionManager.java <https://reviews.apache.org/r/15449/#comment55910> did you mean to use volatile and not transient ? service/src/java/org/apache/hive/service/cli/session/SessionManager.java <https://reviews.apache.org/r/15449/#comment55911> should we put "handleToSession.values()" in a synchronized block as well ? - Thejas Nair On Nov. 13, 2013, 1:21 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15449/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2013, 1:21 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5799 > https://issues.apache.org/jira/browse/HIVE-5799 > > > Repository: hive-git > > > Description > ------- > > Need some timeout facility for preventing resource leakages from instable or > bad clients. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32ab3d8 > conf/hive-default.xml.template c574ab5 > service/src/java/org/apache/hive/service/cli/OperationState.java 1ec6bd1 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 6f4b8dc > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 00058cc > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > cfda752 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > 25c6f38 > > Diff: https://reviews.apache.org/r/15449/diff/ > > > Testing > ------- > > Confirmed in the local environment. > > > Thanks, > > Navis Ryu > >
