----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15588/#review28988 -----------------------------------------------------------
Change looks good to me! Can you trim the trailing ws and then I will +1. - Brock Noland On Nov. 15, 2013, 7:48 p.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15588/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2013, 7:48 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5565 > https://issues.apache.org/jira/browse/HIVE-5565 > > > Repository: hive-git > > > Description > ------- > > Code change is trivial, but a lot of test output needs to be changed. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java a38442d > common/src/test/org/apache/hadoop/hive/common/type/TestHiveDecimal.java > e3a1620 > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 3b87bd6 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java a46ef53 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java e715eb8 > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 2c796e0 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBridge.java > 4f7277b > ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java > f1267d8 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFile.java e857903 > ql/src/test/org/apache/hadoop/hive/ql/parse/TestHiveDecimalParse.java > 01e29af > ql/src/test/queries/clientpositive/decimal_3.q d7e46a6 > ql/src/test/queries/clientpositive/decimal_precision.q da09c6c > ql/src/test/queries/clientpositive/decimal_udf.q a7f8815 > ql/src/test/queries/clientpositive/serde_regex.q b7b611a > ql/src/test/results/clientnegative/invalid_cast_from_binary_1.q.out bae97c3 > ql/src/test/results/clientnegative/invalid_cast_from_binary_2.q.out b036f6a > ql/src/test/results/clientnegative/invalid_cast_from_binary_3.q.out c2cbb0a > ql/src/test/results/clientnegative/invalid_cast_from_binary_4.q.out 60ee51e > ql/src/test/results/clientnegative/invalid_cast_from_binary_5.q.out 2da7787 > ql/src/test/results/clientnegative/invalid_cast_from_binary_6.q.out 4442aff > ql/src/test/results/clientnegative/wrong_column_type.q.out 600f0bb > ql/src/test/results/clientpositive/decimal_3.q.out 3fc814b > ql/src/test/results/clientpositive/decimal_4.q.out 898b8ec > ql/src/test/results/clientpositive/decimal_6.q.out 043321f > ql/src/test/results/clientpositive/decimal_precision.q.out 8af799b > ql/src/test/results/clientpositive/decimal_udf.q.out 1bc0db9 > ql/src/test/results/clientpositive/literal_decimal.q.out 95f3f2e > ql/src/test/results/clientpositive/serde_regex.q.out 64207f1 > ql/src/test/results/clientpositive/udf7.q.out c868453 > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java > 39dde77 > > Diff: https://reviews.apache.org/r/15588/diff/ > > > Testing > ------- > > Unit tests are modified accordingly. Manual testing passsed. > > > Thanks, > > Xuefu Zhang > >
