[ 
https://issues.apache.org/jira/browse/HIVE-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825094#comment-13825094
 ] 

Phabricator commented on HIVE-4632:
-----------------------------------

navis has commented on the revision "HIVE-4632 [jira] Use hadoop counter as a 
stat publisher".

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java:43 I 
was not sure it's always a JobConf. I'll check the type of conf and make new 
JobConf only if needed.
  ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java:69 
done.
  ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsPublisher.java:48 I 
always wondered why there is no string or double type counters, which might be 
useful for complex MR jobs if exists. I'll remove this part.

REVISION DETAIL
  https://reviews.facebook.net/D11001

BRANCH
  HIVE-4632

ARCANIST PROJECT
  hive

To: JIRA, ashutoshc, navis
Cc: ashutoshc


> Use hadoop counter as a stat publisher
> --------------------------------------
>
>                 Key: HIVE-4632
>                 URL: https://issues.apache.org/jira/browse/HIVE-4632
>             Project: Hive
>          Issue Type: Improvement
>          Components: Statistics
>    Affects Versions: 0.12.0
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: D11001.2.patch, HIVE-4632.D11001.1.patch
>
>
> Currently stats are all long/aggregation type and can be safely acquired by 
> hadoop counter without other db or hbase.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to