-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15797/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-5870
https://issues.apache.org/jira/browse/HIVE-5870
Repository: hive-git
Description
-------
TestJDBCDriver2.testNewConnectionConfiguration() attempts to start a
Hiveserver2 instance and test connect to it. This can cause issues as creating
HiveServer2 needs correct environment. This test should be moved to
TestJdbcWithMiniHS2, which uses MiniHS2. MiniHS2 is for this purpose, as it
sets all the environment properly before starting HiveServer2 instance.
This test now runs the same commands against the MiniHS2. In the course of
refactoring, also changed TestJdbcWithMiniHS2's MiniHS2 creation from @Before
to @BeforeClass (ie, once per test), as calling init() multiple times on the
HiveMetastore causes strange errors from DataNucleus/embedded Derby. Also, it
is more efficient.
Diffs
-----
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java
7b1c9da
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java
6c25736
Diff: https://reviews.apache.org/r/15797/diff/
Testing
-------
Ran affected unit tests.
Thanks,
Szehon Ho
