----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16026/#review29794 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java <https://reviews.apache.org/r/16026/#comment57278> instead of specifying "statsPublisher instanceof CounterStatsPublisher", how about to introduce new marker interface for publisher/aggregator something like AccumulatedStatProvider or something? Just a suggestion. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java <https://reviews.apache.org/r/16026/#comment57279> can have a length issue but will be fixed by HIVE-5936. trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <https://reviews.apache.org/r/16026/#comment57280> comments might be fixed accordantly trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java <https://reviews.apache.org/r/16026/#comment57281> would it better to just adding ", e)" in the end? nit: formats - Navis Ryu On Dec. 5, 2013, 1:01 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16026/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 1:01 a.m.) > > > Review request for hive and Navis Ryu. > > > Bugs: HIVE-5916 > https://issues.apache.org/jira/browse/HIVE-5916 > > > Repository: hive > > > Description > ------- > > No need to aggregate statistics collected via counter mechanism > > > Diffs > ----- > > trunk/itests/qtest/pom.xml 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java > 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java > 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java > 1547966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1547966 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java > 1547966 > trunk/ql/src/test/queries/clientpositive/stats_counter_partitioned.q > PRE-CREATION > trunk/ql/src/test/results/clientpositive/stats12.q.out 1547966 > trunk/ql/src/test/results/clientpositive/stats13.q.out 1547966 > trunk/ql/src/test/results/clientpositive/stats_counter_partitioned.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/16026/diff/ > > > Testing > ------- > > Added a new test case. Ran all other stats test. > > > Thanks, > > Ashutosh Chauhan > >
