-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16053/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-5966
    https://issues.apache.org/jira/browse/HIVE-5966


Repository: hive-git


Description
-------

After shims aggregator changes, mvn install would work because all projects had 
dependency to the hadoop-shims uberjar, but eclipse plugin fails because it did 
not understand that dependency.

This patch eliminates the shims uberjar and replacing it with an 
shims-aggregator project, so that both mvn eclipse:eclipse and mvn install will 
work.

Chose only shims-common and shims-common-secure as compile time dependency in 
new shims-aggregator project, the shims-version are runtime dependency.  The 
hive projects are already declaring explicit compile-time dependencies to 
shims-version dependencies.  (In fact, maybe we dont even need dependency from 
shims-aggregator to shims-version?)


Diffs
-----

  shims/aggregator/pom.xml PRE-CREATION 
  shims/assembly/pom.xml a03ebff 
  shims/assembly/src/assemble/uberjar.xml 3eba66d 
  shims/pom.xml 8c14d9b 

Diff: https://reviews.apache.org/r/16053/diff/


Testing
-------

Basic sanity tests with hadoop-2 profile:

Compiled and imported projects to eclipse, verified no error.
Ran a qfile test.
Built the assembly and ran a basic MR query.


Thanks,

Szehon Ho

Reply via email to