----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15993/#review30071 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java <https://reviews.apache.org/r/15993/#comment57612> I don't think we need to call init() from task nodes. Semantics is : init() is called once from client before job is launched. Is there some reason to call init() here now? ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java <https://reviews.apache.org/r/15993/#comment57613> This can simply be written as String spSpec = conf.getStaticSpec(); ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java <https://reviews.apache.org/r/15993/#comment57614> Will be good to add a comment in javadoc about which strings are contained in different positions of array. ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java <https://reviews.apache.org/r/15993/#comment57615> Nice work to batch together these metastore updates. ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java <https://reviews.apache.org/r/15993/#comment57616> invalid semantics (todo) we should probably fix in seperate jira. There I think we need to make a distinction between insert overwrite and insert into cases, for earlier we can replace invalid stats with current value but for insert into they should remain invalid. ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java <https://reviews.apache.org/r/15993/#comment57617> Same comment about needing init() here. ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/15993/#comment57618> Not necessary to fix todo in this jira. But will be good an example where prefix could be longer than maxPrefixLength. ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/15993/#comment57619> Looks like this method is no longer used anywhere. if so, can be removed. - Ashutosh Chauhan On Dec. 10, 2013, 12:42 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15993/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 12:42 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-5936 > https://issues.apache.org/jira/browse/HIVE-5936 > > > Repository: hive-git > > > Description > ------- > > With counter mechanism, MR job is successful, but StatsTask on client fails > with NPE > > > Diffs > ----- > > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStatsAggregator.java > a9c3136 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > d0e94bf > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c43145b > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java cbc3cd2 > ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java bd2c4a8 > ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java a2ecc80 > ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 46d88ce > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 197a20f > > ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanMapper.java > 7e701f4 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java cca8481 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java > af729e6 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 7443ea4 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d0a0ec7 > ql/src/java/org/apache/hadoop/hive/ql/plan/StatsWork.java 0dd0b03 > ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java > fa430eb > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsAggregator.java 661d648 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsFactory.java 8ae32f0 > ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java > fb5f50e > ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java > 8c23b87 > ql/src/test/queries/clientpositive/stats_counter.q 20769e4 > ql/src/test/queries/clientpositive/stats_noscan_2.q a19d01b > ql/src/test/results/clientpositive/stats_counter.q.out f15d8c5 > ql/src/test/results/clientpositive/stats_noscan_1.q.out 5aa6607 > ql/src/test/results/clientpositive/stats_noscan_2.q.out e55fa94 > ql/src/test/results/clientpositive/truncate_column.q.out a247c4a > > Diff: https://reviews.apache.org/r/15993/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
