[
https://issues.apache.org/jira/browse/HIVE-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843900#comment-13843900
]
Phabricator commented on HIVE-2093:
-----------------------------------
navis has commented on the revision "HIVE-2093 [jira] create/drop database
should populate inputs/outputs and check concurrency and user permission".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:510 I've copied it from
somewhere, forget where it was. Could you suggest better state code?
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:737 Ah, sure.
ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:257 This method
seemed not used in anywhere in current codebase, so it's hard to say the intent
of initial contributor(Siying Dong). But this method seemed useful and I'll
change it to return URI for database, too.
ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:83 Some complex
operations like "import" need different privilege checks with that of
initiative operation. I think this part is from HIVE-2818 and mistakenly mixed
with this issue. I'll remove it.
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:2290 ok.
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:1233 ok.
ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java:104
ok.
REVISION DETAIL
https://reviews.facebook.net/D12807
To: JIRA, navis
Cc: thejas
> create/drop database should populate inputs/outputs and check concurrency and
> user permission
> ---------------------------------------------------------------------------------------------
>
> Key: HIVE-2093
> URL: https://issues.apache.org/jira/browse/HIVE-2093
> Project: Hive
> Issue Type: Bug
> Components: Authorization, Locking, Metastore, Security
> Reporter: Namit Jain
> Assignee: Navis
> Attachments: D12807.3.patch, HIVE-2093.6.patch,
> HIVE-2093.7.patch.txt, HIVE-2093.8.patch.txt, HIVE-2093.D12807.1.patch,
> HIVE-2093.D12807.2.patch, HIVE.2093.1.patch, HIVE.2093.2.patch,
> HIVE.2093.3.patch, HIVE.2093.4.patch, HIVE.2093.5.patch
>
>
> concurrency and authorization are needed for create/drop table. Also to make
> concurrency work, it's better to have LOCK/UNLOCK DATABASE and SHOW LOCKS
> DATABASE
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
