-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16207/#review30300
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java
<https://reviews.apache.org/r/16207/#comment58009>

    It would be nice to remove the leading tabs.


- Xuefu Zhang


On Dec. 12, 2013, 8:20 p.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16207/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2013, 8:20 p.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-1466
>     https://issues.apache.org/jira/browse/HIVE-1466
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Support configurable null format for tables and writing out to directory.
> Using a non-default null format is a bit while creating a table, and pretty 
> much impossible to export the data to local filesystem using insert overwrite 
> directory.
> The patch enhances the SQL syntax to support 'NULL DEFINED AS' construct for 
> create table as well as insert overwrite directory.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d32be59 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
> 4b7fc73 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 366b714 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 5e5b8cf 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 8cf5ad6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d0a0ec7 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 93b4181 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java b6097b1 
>   ql/src/test/queries/clientpositive/nullformat.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/nullformatdir.q PRE-CREATION 
>   ql/src/test/results/clientpositive/nullformat.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/nullformatdir.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16207/diff/
> 
> 
> Testing
> -------
> 
> Added new tests.
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>

Reply via email to