----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16422/#review30745 -----------------------------------------------------------
/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java <https://reviews.apache.org/r/16422/#comment58851> Let's just use Entry<String, List<String>>. /trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java <https://reviews.apache.org/r/16422/#comment58850> With the changes made in GenMapRedUtils, we do not expect this check (aliases.contains(mapJoinAlias)) will be true, right? If so, let's add a comment at here tell other code readers that they should not expect to find any conflict on aliases. - Yin Huai On Dec. 20, 2013, 1:01 p.m., Rui Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16422/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2013, 1:01 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5891 > https://issues.apache.org/jira/browse/HIVE-5891 > > > Repository: hive > > > Description > ------- > > Use the query ID as prefix for the join stream intermediate name to avoid > conflict and add sanity check code in CommonJoinTaskDispatcher so that merge > of a MapJoin task into its child MapRed task is skipped if there is any alias > conflict > > > Diffs > ----- > > /trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > 1552475 > > /trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java > 1552475 > /trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java 1552475 > /trunk/ql/src/test/queries/clientpositive/multiMapJoin2.q 1552475 > /trunk/ql/src/test/results/clientpositive/multiMapJoin2.q.out 1552475 > > Diff: https://reviews.apache.org/r/16422/diff/ > > > Testing > ------- > > > Thanks, > > Rui Sun > >
