[
https://issues.apache.org/jira/browse/HIVE-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857548#comment-13857548
]
Brock Noland commented on HIVE-5260:
------------------------------------
Hey guys, I am struggling to understand this code. Specifically:
1) We call addHBaseResource three separate times, twice for each code path:
https://github.com/apache/hive/blob/3b96b3204e5298bcc252bf6f0f5180bb6119bff1/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java#L331
https://github.com/apache/hive/blob/3b96b3204e5298bcc252bf6f0f5180bb6119bff1/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java#L337
https://github.com/apache/hive/blob/3b96b3204e5298bcc252bf6f0f5180bb6119bff1/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java#L346
2) We copy the jobConf, call addHBaseResources a second time, and then never
use the object?
https://github.com/apache/hive/blob/3b96b3204e5298bcc252bf6f0f5180bb6119bff1/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java#L345
Any idea what is the purpose of doing these things?
> Introduce HivePassThroughOutputFormat that allows Hive to use general purpose
> OutputFormats instead of HiveOutputFormats in StorageHandlers
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-5260
> URL: https://issues.apache.org/jira/browse/HIVE-5260
> Project: Hive
> Issue Type: Sub-task
> Components: HBase Handler, HCatalog
> Affects Versions: 0.12.0
> Reporter: Sushanth Sowmyan
> Assignee: Viraj Bhat
> Fix For: 0.12.0
>
> Attachments: HIVE-5260.2.patch, HIVE-5260.patch
>
>
> This is a task being created to address the hive-side of HIVE-4331.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
