[ https://issues.apache.org/jira/browse/HIVE-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860830#comment-13860830 ]
Thejas M Nair commented on HIVE-5946: ------------------------------------- Thanks Brock, this is very useful change, and it will help in adding more tests. I reviewed the changes and they look good to me. It also sets a good example for writing testable code! As you mention, I don't think we should make this pluggable. Once we make it 'pluggable' it would be considered a public API and we would need to start worrying about backward compatibility for it. > DDL authorization task factory should be better tested > ------------------------------------------------------ > > Key: HIVE-5946 > URL: https://issues.apache.org/jira/browse/HIVE-5946 > Project: Hive > Issue Type: Improvement > Reporter: Brock Noland > Assignee: Brock Noland > Attachments: HIVE-5946.patch > > > Thejas is working on various authorization issues and one element that might > be useful in that effort and increase test coverage and testability would be > perform authorization task creation in a factory. -- This message was sent by Atlassian JIRA (v6.1.5#6160)