----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16007/ -----------------------------------------------------------
(Updated Jan. 6, 2014, 4:31 p.m.) Review request for hive. Changes ------- Latest patch. Bugs: HIVE-5946 https://issues.apache.org/jira/browse/HIVE-5946 Repository: hive-git Description ------- Moves the task creation logic to a factory which is now tested with 20 unit tests. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1f242ea ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java d0807d2 ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 448dae2 ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 8bd0927 ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactory.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestHiveAuthorizationTaskFactory.java PRE-CREATION Diff: https://reviews.apache.org/r/16007/diff/ Testing ------- 20 additional unit tests which pass Thanks, Brock Noland