----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16727/#review31458 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java <https://reviews.apache.org/r/16727/#comment59955> Okay. This is another unfortuante inconsistency among different part of Hive code. It seems unfair to ask you to make this consistent in this JIRA, but could you at least put some comments so that we know why for the days ahead? ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java <https://reviews.apache.org/r/16727/#comment59954> Okay. Either way, I think this needs to be consistent with Partition.getPartitionPath() in terms of error handling. - Xuefu Zhang On Jan. 9, 2014, 1:57 a.m., Shuaishuai Nie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16727/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2014, 1:57 a.m.) > > > Review request for hive, Thejas Nair and Xuefu Zhang. > > > Bugs: HIVE-5446 > https://issues.apache.org/jira/browse/HIVE-5446 > > > Repository: hive-git > > > Description > ------- > > Hive cannot select from external table with location has "+" or space in the > path > > > Diffs > ----- > > data/files/ext_test_space/folder+with PRE-CREATION > itests/qtest/pom.xml 119ddb5 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 0fe260d > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 877d342 > > ql/src/test/queries/clientpositive/external_table_with_space_in_location_path.q > PRE-CREATION > > ql/src/test/results/clientpositive/external_table_with_space_in_location_path.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/16727/diff/ > > > Testing > ------- > > > Thanks, > > Shuaishuai Nie > >
