[ https://issues.apache.org/jira/browse/HIVE-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868886#comment-13868886 ]
Hive QA commented on HIVE-6185: ------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12622513/HIVE-6185.1.patch {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 4917 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_14_managed_location_over_existing {noformat} Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/866/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/866/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12622513 > DDLTask is inconsistent in creating a table and adding a partition when > dealing with location > --------------------------------------------------------------------------------------------- > > Key: HIVE-6185 > URL: https://issues.apache.org/jira/browse/HIVE-6185 > Project: Hive > Issue Type: Bug > Components: Query Processor > Affects Versions: 0.12.0 > Reporter: Xuefu Zhang > Assignee: Xuefu Zhang > Attachments: HIVE-6185.1.patch, HIVE-6185.patch, HIVE-6185.patch > > > When creating a table, Hive uses URI to represent location: > {code} > if (crtTbl.getLocation() != null) { > tbl.setDataLocation(new Path(crtTbl.getLocation()).toUri()); > } > {code} > When adding a partition, Hive uses Path to represent location: > {code} > // set partition path relative to table > db.createPartition(tbl, addPartitionDesc.getPartSpec(), new Path(tbl > .getPath(), addPartitionDesc.getLocation()), > addPartitionDesc.getPartParams(), > addPartitionDesc.getInputFormat(), > addPartitionDesc.getOutputFormat(), > addPartitionDesc.getNumBuckets(), > addPartitionDesc.getCols(), > addPartitionDesc.getSerializationLib(), > addPartitionDesc.getSerdeParams(), > addPartitionDesc.getBucketCols(), > addPartitionDesc.getSortCols()); > {code} > This disparity makes the values stored in metastore be encoded differently, > causing problems w.r.t. special character as demonstrated in HIVE-5446. As a > result, the code dealing with location for table is different for partition, > creating maintenance burden. > We need to standardize it to Path to be in line with other Path related > cleanup effort. -- This message was sent by Atlassian JIRA (v6.1.5#6160)