> On Jan. 22, 2014, 7:58 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java, > > line 27 > > <https://reviews.apache.org/r/17163/diff/2/?file=433855#file433855line27> > > > > If we make it extend HiveException than we can avoid all those > > try-catches which catch this exception and rethrow HiveException.
If we extend HiveException, HiveException has to become a public API, and so does ErrorMsg . It didn't seem like a good idea to make ErrorMsg public. Let me know if you think otherwise. > On Jan. 22, 2014, 7:58 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java, > > line 32 > > <https://reviews.apache.org/r/17163/diff/2/?file=433861#file433861line32> > > > > This can be removed. fixing > On Jan. 22, 2014, 7:58 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/authorization_1_sql_std.q, line 13 > > <https://reviews.apache.org/r/17163/diff/2/?file=433864#file433864line13> > > > > If you don't intent to have this in test case, better to just delete it. fixing > On Jan. 22, 2014, 7:58 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/authorization_1_sql_std.q, line 27 > > <https://reviews.apache.org/r/17163/diff/2/?file=433864#file433864line27> > > > > Same as above. fixing - Thejas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17163/#review32517 ----------------------------------------------------------- On Jan. 22, 2014, 12:17 a.m., Thejas Nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17163/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 12:17 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-5929 > https://issues.apache.org/jira/browse/HIVE-5929 > > > Repository: hive-git > > > Description > ------- > > Subtask for sql standard based auth, for performing the updates to metastore > from newly supported access control statements . > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java bd95161 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 92ed55b > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java c65bf28 > > ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java > c41cd0f > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationUtils.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/DefaultHiveAuthorizerFactory.java > 7470e9d > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessController.java > 8e4114f > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationPluginException.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java > 63046f5 > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java > c10a2ac > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java > ca95bfc > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeInfo.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizerFactory.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f7fec > ql/src/test/queries/clientpositive/authorization_1_sql_std.q PRE-CREATION > ql/src/test/queries/clientpositive/authorization_role_grant1.q 1a375a5 > ql/src/test/results/clientpositive/authorization_1_sql_std.q.out > PRE-CREATION > ql/src/test/results/clientpositive/authorization_role_grant1.q.out 496687c > > Diff: https://reviews.apache.org/r/17163/diff/ > > > Testing > ------- > > .q tests included. > > > Thanks, > > Thejas Nair > >
