The wiki still has Phabricator information, with nothing about Apache's review board.
How to Contribute: Review Process<https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-ReviewProcess> > See Phabricator<https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview> for > instructions. > > - Use Hadoop's code review > checklist<http://wiki.apache.org/hadoop/CodeReviewChecklist> as > a rough guide when doing reviews. > > > - In JIRA, use 'Submit Patch' to get your review request into the > queue. > > > - If a committer requests changes, set the issue status to 'Resume > Progress', then once you're ready, submit an updated patch with necessary > fixes and then request another round of review with 'Submit Patch' again. > > > - Once your patch is accepted, be sure to upload a final version which > grants rights to the ASF. > > Would someone please update this section with the appropriate link to review board instructions? I'm a review board newbie (or wanna-be) but can't even get registration to work so I won't volunteer. Should the link go to http://www.reviewboard.org/docs/manual/1.7/? -- Lefty On Sat, Oct 19, 2013 at 12:10 PM, Prasad Mujumdar <[email protected]>wrote: > +1 (non-binding) > Its good to use a common review tool and one that's has no third party > dependency. > > thanks > Prasad > > > > > On Fri, Oct 18, 2013 at 1:59 PM, Ashutosh Chauhan <[email protected] > >wrote: > > > 0 > > > > IMO phabricator interface is better than review board, but threat of > losing > > comments and patches is also real. > > Actually, we already lost in few cases, ironically it was RB. Try to read > > the very first review request posted on HIVE-1634 > > > > Ashutosh > > > > > > On Thu, Oct 17, 2013 at 6:55 PM, Yin Huai <[email protected]> wrote: > > > > > +1 > > > > > > > > > On Thu, Oct 17, 2013 at 5:51 PM, Gunther Hagleitner < > > > [email protected]> wrote: > > > > > > > +1 > > > > > > > > Thanks, > > > > Gunther. > > > > > > > > > > > > On Thu, Oct 17, 2013 at 2:18 PM, Owen O'Malley <[email protected]> > > > wrote: > > > > > > > > > Ed, > > > > > I didn't remember being unable to see revisions without a login. > > That > > > > is > > > > > uncool. I'll change my vote to +1. > > > > > > > > > > -- Owen > > > > > > > > > > > > > > > On Wed, Oct 16, 2013 at 9:08 PM, Edward Capriolo < > > > [email protected] > > > > > >wrote: > > > > > > > > > > > Owen, > > > > > > In your issues: > > > > > > https://issues.apache.org/jira/browse/HIVE-5567 > > > > > > > > > > > > When I click this link: > > > > > > REVISION DETAIL > > > > > > https://reviews.facebook.net/D13479 > > > > > > > > > > > > I am prompted for a password. > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Oct 16, 2013 at 11:16 PM, Owen O'Malley < > > > > [email protected] > > > > > > >wrote: > > > > > > > > > > > > > -0 > > > > > > > > > > > > > > I like phabricator, but it is a pain to setup. It doesn't > > require a > > > > fb > > > > > > > account, but clearly it isn't managed or supported by Apache. > > > > > > > > > > > > > > -- Owen > > > > > > > > > > > > > > > On Oct 16, 2013, at 17:32, Edward Capriolo < > > > [email protected]> > > > > > > > wrote: > > > > > > > > > > > > > > > > Our wiki has instructions for posting to phabricator for code > > > > > reviews. > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview > > > > > > > > > > > > > > > > Phabricator now requires an external facebook account to > review > > > > > > patches, > > > > > > > > and we have no technical support contact where phabricator is > > > > hosted. > > > > > > It > > > > > > > > also seems like some of the phabricator features are no > longer > > > > > working. > > > > > > > > > > > > > > > > Apache has a review board system many people are already > using. > > > > > > > > > > https://reviews.apache.org/account/login/?next_page=/dashboard/ > > > > > > > > > > > > > > > > This vote is to remove the phabricator instructions from the > > > wiki. > > > > > The > > > > > > > > instructions will reference review board and that will be the > > > only > > > > > > system > > > > > > > > that Hive supports for patch review process. > > > > > > > > > > > > > > > > +1 is a vote for removing the phabricator instructions from > the > > > > wiki. > > > > > > > > > > > > > > > > Thank you, > > > > > > > > Edward > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > CONFIDENTIALITY NOTICE > > > > NOTICE: This message is intended for the use of the individual or > > entity > > > to > > > > which it is addressed and may contain information that is > confidential, > > > > privileged and exempt from disclosure under applicable law. If the > > reader > > > > of this message is not the intended recipient, you are hereby > notified > > > that > > > > any printing, copying, dissemination, distribution, disclosure or > > > > forwarding of this communication is strictly prohibited. If you have > > > > received this communication in error, please contact the sender > > > immediately > > > > and delete it from your system. Thank You. > > > > > > > > > >
