----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17005/#review32855 -----------------------------------------------------------
Please see my comment about the scale. Otherwise, it looks good to me. ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java <https://reviews.apache.org/r/17005/#comment61854> For safety, you could put a check here and throw an exception if scratchScaleVector.vector[I] is not equal to result.vector[I].scale. Alternatively, you could make the value NULL if that is the case, and maybe log an error. - Eric Hanson On Jan. 24, 2014, 10:28 p.m., Jitendra Pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17005/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 10:28 p.m.) > > > Review request for hive and Eric Hanson. > > > Bugs: HIVE-6178 > https://issues.apache.org/jira/browse/HIVE-6178 > > > Repository: hive-git > > > Description > ------- > > vectorized reader for DECIMAL datatype for ORC format. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java 3939511 > common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java > d71ebb3 > common/src/test/org/apache/hadoop/hive/common/type/TestUnsignedInt128.java > fbb2aa0 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/DecimalColumnVector.java > 23564bb > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 0df82b9 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedORCReader.java > 0d5b7ff > > Diff: https://reviews.apache.org/r/17005/diff/ > > > Testing > ------- > > > Thanks, > > Jitendra Pandey > >
