----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17422/#review33034 -----------------------------------------------------------
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestSSL.java <https://reviews.apache.org/r/17422/#comment62193> thanks for restructuring these into conf overlays! itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java <https://reviews.apache.org/r/17422/#comment62244> do we need this sleep ? If we can avoid this 2 secs of sleep per test (with miniHS2.stop()), that would be great. Doesn't the HS2.stop block on completion ? jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java <https://reviews.apache.org/r/17422/#comment62247> instead of a TODO comment, you can probably just say the format that is supported/not supported, see HIVE-6286 jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java <https://reviews.apache.org/r/17422/#comment62249> i think boolean instead of Boolean is better here. It is simpler, as you don't have to think if the value can be NULL in other parts of the code where it is passed around. jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java <https://reviews.apache.org/r/17422/#comment62253> If user has specified "https" in url, should we honor that, and switch to ssl ? That seems like a good intuitive experience. service/pom.xml <https://reviews.apache.org/r/17422/#comment62254> what is the reason for change in library? - Thejas Nair On Jan. 28, 2014, 12:37 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17422/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 12:37 a.m.) > > > Review request for hive, Prasad Mujumdar and Thejas Nair. > > > Bugs: HIVE-5826 > https://issues.apache.org/jira/browse/HIVE-5826 > > > Repository: hive-git > > > Description > ------- > > Here: https://issues.apache.org/jira/browse/HIVE-5826 > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > b271d65 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestSSL.java d0c4fc2 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/AbstarctHiveService.java > 5ecd156 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java > PRE-CREATION > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java > a65e678 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2.java > 910de9b > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/thrift/TestThriftHttpCLIService.java > 65177dd > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java aabb5cb > pom.xml 41f5337 > service/pom.xml dff3174 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > b5a6138 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > e487a7f > service/src/java/org/apache/hive/service/server/HiveServer2.java fa13783 > > Diff: https://reviews.apache.org/r/17422/diff/ > > > Testing > ------- > > New tests added to TestSSL, some refactoring of MiniHS2 as well. > > > Thanks, > > Vaibhav Gumashta > >
