----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17470/#review33083 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g <https://reviews.apache.org/r/17470/#comment62331> These are existing keywords that are already present in IdentifiersParser.g non reserved keywords. ql/src/test/queries/clientnegative/authorization_invalid_priv_v1.q <https://reviews.apache.org/r/17470/#comment62332> We have positive tests for sql std auth mode grant statements in - ql/src/test/queries/clientpositive/authorization_1_sql_std.q There will be more coming as part of specific grant statement features. Also TestPrivilegesV2.java has positive checks. ql/src/test/queries/clientnegative/authorization_invalid_priv_v2.q <https://reviews.apache.org/r/17470/#comment62334> Since Index is one of the privilege types that are not supported by this authorization mode, it used in this negative test. - Thejas Nair On Jan. 28, 2014, 10:30 p.m., Thejas Nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17470/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 10:30 p.m.) > > > Review request for hive. > > > Bugs: HIVE-6112 > https://issues.apache.org/jira/browse/HIVE-6112 > > > Repository: hive-git > > > Description > ------- > > Add INSERT, DELETE privileges for SQL Standard auth. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 216c361 > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/Privilege.java > dbbe210 > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeRegistry.java > 960f291 > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeType.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java > 7425150 > > ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/AuthorizationTestUtil.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/ListSizeMatcher.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/PrivilegesTestBase.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestHiveAuthorizationTaskFactory.java > 77148b8 > > ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestPrivilegesV1.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestPrivilegesV2.java > PRE-CREATION > ql/src/test/queries/clientnegative/authorization_invalid_priv_v1.q > PRE-CREATION > ql/src/test/queries/clientnegative/authorization_invalid_priv_v2.q > PRE-CREATION > ql/src/test/results/clientnegative/authorization_invalid_priv_v1.q.out > PRE-CREATION > ql/src/test/results/clientnegative/authorization_invalid_priv_v2.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/17470/diff/ > > > Testing > ------- > > unit tests and .q tests > > > Thanks, > > Thejas Nair > >
