----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16910/#review33327 -----------------------------------------------------------
Ship it! Ship It! beeline/src/java/org/apache/hive/beeline/BeeLine.java <https://reviews.apache.org/r/16910/#comment62768> May be its not immediately clear from the context here, but is it possible for args[++i] to throw an ArrayIndexOutOfBoundsException if args.size() == i - Swarnim Kulkarni On Jan. 30, 2014, 10:28 p.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16910/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 10:28 p.m.) > > > Review request for hive. > > > Bugs: HIVE-6173 > https://issues.apache.org/jira/browse/HIVE-6173 > > > Repository: hive-git > > > Description > ------- > > Introduced --hiveconf option on beeline option. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java c5e36a5 > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 04802bc > beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java a4b34c7 > beeline/src/main/resources/BeeLine.properties 408286d > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > 0560fe8 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 6e73d80 > > Diff: https://reviews.apache.org/r/16910/diff/ > > > Testing > ------- > > Unit test added. > > > Thanks, > > Xuefu Zhang > >
