[
https://issues.apache.org/jira/browse/HIVE-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888658#comment-13888658
]
Brock Noland commented on HIVE-6347:
------------------------------------
There are a number of cases there the if contains a negation
but there is an else condition. Thse should be swapped:
e.g
if (!bool) else => if (bool) else
{noformat}
+ if(zcr != null) {
+ while(len > 0) {
+ ByteBuffer partial = zcr.readBuffer(len, false);
+ result.add(new BufferChunk(partial, off));
+ int read = partial.remaining();
+ len -= read;
+ off += read;
+ }
+ } else {
{noformat}
{noformat}
+ if (ShimLoader.getHadoopShims().getDirectDecompressor(
+ DirectCompressionType.SNAPPY) != null) {
+ direct = Boolean.valueOf(true);
+ } else {
+ direct = Boolean.valueOf(false);
+ }
{noformat}
> ZeroCopy read path for ORC RecordReader
> ---------------------------------------
>
> Key: HIVE-6347
> URL: https://issues.apache.org/jira/browse/HIVE-6347
> Project: Hive
> Issue Type: Bug
> Components: File Formats
> Affects Versions: tez-branch
> Reporter: Gopal V
> Assignee: Gopal V
> Attachments: HIVE-6347.1.patch
>
>
> ORC can use the new HDFS Caching APIs and the ZeroCopy readers to avoid extra
> data copies into memory while scanning files.
> Implement ORC zcr codepath and a hive.orc.zerocopy flag.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
