> On Feb. 8, 2014, 3:26 p.m., Ashutosh Chauhan wrote: > > metastore/if/hive_metastore.thrift, line 331 > > <https://reviews.apache.org/r/17687/diff/5/?file=480446#file480446line331> > > > > Should this be list<String> partitionSpec? Seems like client (if ever) > > will only be intersted in name of partitions which got dropped. Partition > > object is quite bulky.
currently the partitions are added to result; previously the code would retrieve them, now it retrieves them as part of the drop call. > On Feb. 8, 2014, 3:26 p.m., Ashutosh Chauhan wrote: > > metastore/if/hive_metastore.thrift, line 354 > > <https://reviews.apache.org/r/17687/diff/5/?file=480446#file480446line354> > > > > Should this default to false? Otherwise, we will send back list of > > Partition object back to client, which could be huge and in most cases, > > client is not interested in those. it is, it's added to command output by Hive... I was asking about it last time we talked; should we change that? > On Feb. 8, 2014, 3:26 p.m., Ashutosh Chauhan wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 2339 > > <https://reviews.apache.org/r/17687/diff/5/?file=480447#file480447line2339> > > > > I think there is a way to do bulk delete from filesystem. If we fire > > 10K requests on NN to delete dirs, this will take a while. Plus, we will > > swamp NN, when not needed. Further, this might us give better atomicity > > guarantees, than current one. > > If there is no such api on NN, than lets fire jira on HDFS to request > > this. There isn't such an API; HDFS-5916 > On Feb. 8, 2014, 3:26 p.m., Ashutosh Chauhan wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java, > > line 658 > > <https://reviews.apache.org/r/17687/diff/5/?file=480448#file480448line658> > > > > setNeedResult(false) ? See above/our previous discussion > On Feb. 8, 2014, 3:26 p.m., Ashutosh Chauhan wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java, > > line 36 > > <https://reviews.apache.org/r/17687/diff/5/?file=480450#file480450line36> > > > > Looks like this import is unneeded. Also, it seems like currently bulk > > deletion is supported only via orm? Are you planning to do bulk deletion > > via direct sql in subsequent jira ? > > Asking because since perf is major driver for this work and in past we > > have seen major diff between direct sql and orm perf. Filed HIVE-6397. This is risky, would need to investigate, maybe ask DN guys on SO > On Feb. 8, 2014, 3:26 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java, line > > 2406 > > <https://reviews.apache.org/r/17687/diff/5/?file=480461#file480461line2406> > > > > Do we need both of these two boolean variables? it's for clarity (and may change, see comment above) - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17687/#review34020 ----------------------------------------------------------- On Feb. 7, 2014, 10:55 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17687/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 10:55 p.m.) > > > Review request for hive, Ashutosh Chauhan and Gunther Hagleitner. > > > Repository: hive-git > > > Description > ------- > > See jira. > > > Diffs > ----- > > metastore/if/hive_metastore.thrift c8b58bd > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 4905be0 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > bcbb52e > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 377709f > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 4306699 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > e18e13f > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 0715e22 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 2e3b6da > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 6998b43 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > f54ae53 > ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java 598be11 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 32831fa > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e59decc > ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java 46f96ce > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java d13d0b0 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 9f15609 > ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java 97f0f72 > > Diff: https://reviews.apache.org/r/17687/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
