----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18002/#review34350 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java <https://reviews.apache.org/r/18002/#comment64408> The patch seems to have tab characters in many places. - Jitendra Pandey On Feb. 12, 2014, 12:30 p.m., Remus Rusanu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18002/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 12:30 p.m.) > > > Review request for hive, Eric Hanson and Jitendra Pandey. > > > Bugs: HIVE-6344 and HIVE-6345 > https://issues.apache.org/jira/browse/HIVE-6344 > https://issues.apache.org/jira/browse/HIVE-6345 > > > Repository: hive-git > > > Description > ------- > > See HIVE-6344 and HIVE-6345 > > > Diffs > ----- > > ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 1b76fc9 > common/src/java/org/apache/hadoop/hive/common/type/Decimal128.java 2e0f058 > common/src/java/org/apache/hadoop/hive/common/type/UnsignedInt128.java > fb3c346 > common/src/java/org/apache/hive/common/util/Decimal128FastBuffer.java > PRE-CREATION > ql/src/gen/vectorization/UDAFTemplates/VectorUDAFAvg.txt cb94145 > ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMax.txt 2b0364c > ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMaxDecimal.txt > PRE-CREATION > ql/src/gen/vectorization/UDAFTemplates/VectorUDAFMinMaxString.txt 36f483e > ql/src/gen/vectorization/UDAFTemplates/VectorUDAFSum.txt 3573997 > ql/src/gen/vectorization/UDAFTemplates/VectorUDAFVar.txt 7c0e58f > ql/src/gen/vectorization/UDAFTemplates/VectorUDAFVarDecimal.txt > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorColumnAssignFactory.java > d1a75df > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java > d9855c1 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java > f083d86 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapperBatch.java > e978110 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOperator.java > 036f080 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 7141d63 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java > d409d44 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFAvgDecimal.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFSumDecimal.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java > 1a00800 > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java > a2b45f8 > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/util/FakeVectorRowBatchFromObjectIterables.java > c8eaea1 > ql/src/test/queries/clientpositive/vector_decimal_aggregate.q PRE-CREATION > ql/src/test/queries/clientpositive/vector_decimal_mapjoin.q PRE-CREATION > ql/src/test/results/clientpositive/vector_decimal_aggregate.q.out > PRE-CREATION > ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out > PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/io/HiveDecimalWritable.java > 008fda3 > > serde/src/test/org/apache/hadoop/hive/serde2/io/TestHiveDecimalWritable.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/18002/diff/ > > > Testing > ------- > > Manual, new units, new .q/.out > > > Thanks, > > Remus Rusanu > >
