----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18172/#review34602 -----------------------------------------------------------
conf/hive-default.xml.template <https://reviews.apache.org/r/18172/#comment64764> max joins is missing. ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/CostBasedOptimizer.java <https://reviews.apache.org/r/18172/#comment64765> if this is meant to be a generic contract this shouldn't be in the optiq package. ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/CostBasedOptimizer.java <https://reviews.apache.org/r/18172/#comment64763> Why can't we use a generic type here? - Gunther Hagleitner On Feb. 16, 2014, 8:39 p.m., Harish Butani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18172/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2014, 8:39 p.m.) > > > Review request for hive. > > > Bugs: HIVE-6439 > https://issues.apache.org/jira/browse/HIVE-6439 > > > Repository: hive-git > > > Description > ------- > > This patch introduces CBO step in SemanticAnalyzer. For now the > CostBasedOptimizer is an empty shell. > The contract between SemAly and CBO is: > CBO step is controlled by the 'hive.enable.cbo.flag'. > When true Hive SemAly will hand CBO a Hive Operator tree (with operators > annotated with stats). If it can CBO will return a better plan in Hive AST > form. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a182cd7 > conf/hive-default.xml.template 0d08aa2 > ql/src/java/org/apache/hadoop/hive/ql/QueryProperties.java 1ba5654 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/PreCBOOptimizer.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/CostBasedOptimizer.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseDriver.java 52c39c0 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 77388dd > > Diff: https://reviews.apache.org/r/18172/diff/ > > > Testing > ------- > > > Thanks, > > Harish Butani > >
