> On Feb. 14, 2014, 4:35 p.m., Swarnim Kulkarni wrote: > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseCompositeKey.java, > > line 106 > > <https://reviews.apache.org/r/18122/diff/1/?file=485256#file485256line106> > > > > Javadoc on this factory class would be very helpful for consumers.
sure > On Feb. 14, 2014, 4:35 p.m., Swarnim Kulkarni wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyObjectBase.java, line > > 21 > > <https://reviews.apache.org/r/18122/diff/1/?file=485270#file485270line21> > > > > Are we not breaking our consumers with this non-passive change? > > > > If we want to go this route, may be we should deprecate out the > > existing abstract class. LazyObjectBase is an internal class and user are not supposed to use that. We may create another interface but it felt a little waste to me. > On Feb. 14, 2014, 4:35 p.m., Swarnim Kulkarni wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java, line 182 > > <https://reviews.apache.org/r/18122/diff/1/?file=485271#file485271line182> > > > > Nit: Could change this to SerDeException to catch that specific checked > > exception ok. - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18122/#review34498 ----------------------------------------------------------- On Feb. 14, 2014, 3:19 p.m., Swarnim Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18122/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 3:19 p.m.) > > > Review request for hive, Brock Noland, Navis Ryu, and Swarnim Kulkarni. > > > Bugs: HIVE-6411 > https://issues.apache.org/jira/browse/HIVE-6411 > > > Repository: hive-git > > > Description > ------- > > Refer to description on HIVE-6411. > > > Diffs > ----- > > hbase-handler/pom.xml 7c3524c > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseCompositeKey.java > 5008f15 > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseKeyFactory.java > PRE-CREATION > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseLazyObjectFactory.java > PRE-CREATION > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 2cd65cb > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java > 8cd594b > hbase-handler/src/java/org/apache/hadoop/hive/hbase/LazyHBaseRow.java > fc40195 > > hbase-handler/src/test/org/apache/hadoop/hive/hbase/TestHBaseKeyFactory.java > PRE-CREATION > hbase-handler/src/test/queries/positive/hbase_custom_key.q PRE-CREATION > hbase-handler/src/test/results/positive/hbase_custom_key.q.out PRE-CREATION > itests/util/pom.xml 9885c53 > serde/src/java/org/apache/hadoop/hive/serde2/StructObject.java PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/StructObjectBaseInspector.java > PRE-CREATION > > serde/src/java/org/apache/hadoop/hive/serde2/columnar/ColumnarStructBase.java > 1fd6853 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyObject.java 10f4c05 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyObjectBase.java > 3334dff > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyStruct.java 8a1ea46 > > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java > 8a5386a > > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryObject.java > 598683f > > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryStruct.java > caf3517 > > Diff: https://reviews.apache.org/r/18122/diff/ > > > Testing > ------- > > > Thanks, > > Swarnim Kulkarni > >
