> On Feb. 25, 2014, 9:47 p.m., Thejas Nair wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java, line 256 > > <https://reviews.apache.org/r/18185/diff/2/?file=503326#file503326line256> > > > > this variable is not being used anywhere > >
> On Feb. 25, 2014, 9:47 p.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/auth/HttpCLIServiceProcessor.java, > > line 25 > > <https://reviews.apache.org/r/18185/diff/2/?file=503332#file503332line25> > > > > can you add a class comment ? Actually as pointed by you earlier, this is kinda redundant. Getting rid of it. > On Feb. 25, 2014, 9:47 p.m., Thejas Nair wrote: > > shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java, > > line 48 > > <https://reviews.apache.org/r/18185/diff/2/?file=503342#file503342line48> > > > > wouldn't it be sufficient to use HadoopShims.getUGIForConf() instead of > > new method in thrift shims ? > > HadoopShims.getUGIForConf() doesn't end up using the conf at all. For our case we want to make sure that the UGI is created with the given conf which has the authType as kerberos. > On Feb. 25, 2014, 9:47 p.m., Thejas Nair wrote: > > shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java, > > line 96 > > <https://reviews.apache.org/r/18185/diff/2/?file=503340#file503340line96> > > > > This is duplicating code in createClientTransport . Should we move this > > code to a static util class and re-use in both places ? > > It might get a little unclean if I try to do that. In http code, I want to get the serverPrincipal back (after verifying that it has 3 components) but in the code elsewhere in this class, it wants to use names[]. - Vaibhav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18185/#review35436 ----------------------------------------------------------- On Feb. 26, 2014, 2:59 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18185/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 2:59 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-4764 > https://issues.apache.org/jira/browse/HIVE-4764 > > > Repository: hive-git > > > Description > ------- > > Support Kerberos HTTP authentication for HiveServer2 running in http mode > > > Diffs > ----- > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 4102d7a > jdbc/src/java/org/apache/hive/jdbc/HttpBasicAuthInterceptor.java 66eba1b > jdbc/src/java/org/apache/hive/jdbc/HttpKerberosRequestInterceptor.java > PRE-CREATION > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java d8ba3aa > service/src/java/org/apache/hive/service/auth/HttpAuthUtils.java > PRE-CREATION > > service/src/java/org/apache/hive/service/auth/HttpAuthenticationException.java > PRE-CREATION > > service/src/java/org/apache/hive/service/auth/HttpCLIServiceUGIProcessor.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/CLIService.java 2b1e712 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > bfe0e7b > > service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java > 6fbc847 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 26bda5a > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > a6ff6ce > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java > e77f043 > > shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java > dc89de1 > shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java > 9e9a60d > > shims/common/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge.java > 03f4e51 > > Diff: https://reviews.apache.org/r/18185/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
