----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17483/#review36053 -----------------------------------------------------------
Look good. Minor comment on code style. hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java <https://reviews.apache.org/r/17483/#comment66883> Could you fix the indent/format here to be consistent with hive code style? - Xuefu Zhang On March 3, 2014, 11:40 p.m., Swarnim Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17483/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 11:40 p.m.) > > > Review request for hive. > > > Bugs: HIVE-6290 > https://issues.apache.org/jira/browse/HIVE-6290 > > > Repository: hive-git > > > Description > ------- > > Support to be able to provide scan filter for hive/hbase integration for > composite keys. > > > Diffs > ----- > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseCompositeKey.java > 5008f15 > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java > 8cd594b > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java > 704fcb9 > > hbase-handler/src/test/org/apache/hadoop/hive/hbase/HBaseTestCompositeKey.java > 13c344b > ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java > d39ee2e > ql/src/java/org/apache/hadoop/hive/ql/index/IndexSearchCondition.java > 5f1329c > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java e50026b > > Diff: https://reviews.apache.org/r/17483/diff/ > > > Testing > ------- > > Tested using locally created data and debug logs that the filter gets applied > on the scan. > > > Thanks, > > Swarnim Kulkarni > >
