----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18757/#review36205 -----------------------------------------------------------
http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java <https://reviews.apache.org/r/18757/#comment67145> can you take fix this indentation ? is it having tabs instead of spaces ? http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java <https://reviews.apache.org/r/18757/#comment67146> The indentation here is also off. - Thejas Nair On March 4, 2014, 11:14 p.m., Shivaraju Gowda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18757/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 11:14 p.m.) > > > Review request for hive, Kevin Minder, Prasad Mujumdar, Thejas Nair, and > Vaibhav Gumashta. > > > Bugs: HIVE-6486 > https://issues.apache.org/jira/browse/HIVE-6486 > > > Repository: hive > > > Description > ------- > > Support secure Subject.doAs() in HiveServer2 JDBC client. > > Original review: https://reviews.apache.org/r/18464/ > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java > 1574208 > > http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java > 1574208 > > http://svn.apache.org/repos/asf/hive/trunk/service/src/java/org/apache/hive/service/auth/TSubjectAssumingTransport.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/18757/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Shivaraju Gowda > >
