----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18936/#review36680 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMultiHashMap.java <https://reviews.apache.org/r/18936/#comment67786> This would be much simpler if you split up the details into 2 groups. 1) Finding the key 2) Finding the value(s) Because #1 is well understood for closed hashtables. And #2 is where all the complexity is for this impl, with the multi value linked list via offsets implementation. ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMultiHashMap.java <https://reviews.apache.org/r/18936/#comment67737> This should be an IllegalArgumentException - we don't run asserts in production. ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMultiHashMap.java <https://reviews.apache.org/r/18936/#comment67740> Quadriatic probing is much nicer for collisions. ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMultiHashMap.java <https://reviews.apache.org/r/18936/#comment67742> if cmpLength != keylength comparison - cannot be equal if they are not byte-for-byte equal, right? ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOperator.java <https://reviews.apache.org/r/18936/#comment67748> why is there an init()? serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java <https://reviews.apache.org/r/18936/#comment67736> Comment eaten up in diff? - Gopal V On March 8, 2014, 12:31 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18936/ > ----------------------------------------------------------- > > (Updated March 8, 2014, 12:31 a.m.) > > > Review request for hive, Gopal V and Gunther Hagleitner. > > > Repository: hive-git > > > Description > ------- > > See JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java edc3d38 > ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java > 170e8c0 > ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 3daf7a5 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractMapJoinTableContainer.java > 8854b19 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/BytesBytesMultiHashMap.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HashMapWrapper.java > 61545b5 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinBytesTableContainer.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinKey.java > a00aab3 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinPersistableTableContainer.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinRowContainer.java > 008a8db > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainer.java > a8cb1ae > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainerSerDe.java > 55b7415 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HashTableLoader.java 84739ee > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOperator.java > 6ecbcf7 > > ql/src/test/org/apache/hadoop/hive/ql/exec/persistence/TestMapJoinEqualityTableContainer.java > 65e3779 > > ql/src/test/org/apache/hadoop/hive/ql/exec/persistence/TestMapJoinTableContainer.java > 755d783 > ql/src/test/queries/clientpositive/mapjoin_mapjoin.q 1eb95f6 > ql/src/test/results/clientpositive/mapjoin_mapjoin.q.out d79b984 > ql/src/test/results/clientpositive/tez/mapjoin_mapjoin.q.out bc2c650 > serde/src/java/org/apache/hadoop/hive/serde2/ByteStream.java 73d9b29 > serde/src/java/org/apache/hadoop/hive/serde2/WriteBuffers.java PRE-CREATION > > serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java > bab505e > serde/src/java/org/apache/hadoop/hive/serde2/io/DateWritable.java 1f4ccdd > serde/src/java/org/apache/hadoop/hive/serde2/io/HiveDecimalWritable.java > a99c7b4 > serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java > 435d6c6 > > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java > b188c3f > > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java > 6c14081 > > Diff: https://reviews.apache.org/r/18936/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
