[ 
https://issues.apache.org/jira/browse/HIVE-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13929892#comment-13929892
 ] 

Ashutosh Chauhan commented on HIVE-5931:
----------------------------------------

Patch looks good. I have a minor comment on RB. 
Although, I think following syntax  is better :
{code}
SHOW PRINCIPALS role_name;
{code}
having role there is redundant. 

> SQL std auth - add metastore get_principals_in_role api, support SHOW ROLE 
> PRINCIPALS
> -------------------------------------------------------------------------------------
>
>                 Key: HIVE-5931
>                 URL: https://issues.apache.org/jira/browse/HIVE-5931
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Authorization
>            Reporter: Thejas M Nair
>         Attachments: HIVE-5931.1.patch, HIVE-5931.nothrifgen.1.patch, 
> HIVE-5931.thriftapi.2.patch, HIVE-5931.thriftapi.3.patch, 
> HIVE-5931.thriftapi.followup.patch, HIVE-5931.thriftapi.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Support command for listing all members of a role.
> A new metastore api call also needs to be added for this.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to