----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19503/#review38131 -----------------------------------------------------------
The patch look fine. Certainly a useful functionality! I am a bit concern about the behavior change introduced here. The existing client applications that are not expecting fully qualified column name would break as after this patch. It will require application code change to work with the new driver. IMO we should have config property to restore the old behavior when needed. The default should be the new behavior. - Prasad Mujumdar On March 20, 2014, 10:24 p.m., Harish Butani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19503/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 10:24 p.m.) > > > Review request for hive. > > > Bugs: hive-6687 > https://issues.apache.org/jira/browse/hive-6687 > > > Repository: hive-git > > > Description > ------- > > JDBC ResultSet fails to get value by qualified projection name > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java > dac62d5 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > c91df83 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e1e427f > > Diff: https://reviews.apache.org/r/19503/diff/ > > > Testing > ------- > > > > > Thanks, > > Harish Butani > >
