I think all three are now ready to be committed. I addressed all comments and reviews and the test failures look unrelated to me.
On Fri, Mar 21, 2014 at 12:39 AM, Lars Francke <lars.fran...@gmail.com> wrote: > Thanks everyone for jumping on this. I'll get to your comments on all > three issues tomorrow! > > On Thu, Mar 20, 2014 at 9:03 PM, kulkarni.swar...@gmail.com > <kulkarni.swar...@gmail.com> wrote: >> Left few minor comments on the JIRAs >> >> >> On Thu, Mar 20, 2014 at 2:42 PM, kulkarni.swar...@gmail.com < >> kulkarni.swar...@gmail.com> wrote: >> >>> I am also definitely willing to help out with reviewing the JIRAs. Just my >>> +1 won't matter much as it is non-binding. :) >>> >>> >>> On Thu, Mar 20, 2014 at 1:21 PM, Lefty Leverenz >>> <leftylever...@gmail.com>wrote: >>> >>>> I gave HIVE-6331 <https://issues.apache.org/jira/browse/HIVE-6331> a +1 >>>> and >>>> asked for a trivial fix in >>>> HIVE-5652<https://issues.apache.org/jira/browse/HIVE-5652>, >>>> then I'll give it +1 also. >>>> >>>> But I can't vouch for the technical information except as far as common >>>> sense takes me. So can someone else take a look too? >>>> >>>> -- Lefty >>>> >>>> >>>> On Thu, Mar 20, 2014 at 12:46 PM, Xuefu Zhang <xzh...@cloudera.com> >>>> wrote: >>>> >>>> > Thanks for reaching out. Since the first two were initially reviewed by >>>> > Lefty, it's better to get her +1 in order to be committed if she's >>>> > available. >>>> > >>>> > I can take a look at HIVE-6510. >>>> > >>>> > Thanks, >>>> > Xuefu >>>> > >>>> > >>>> > On Thu, Mar 20, 2014 at 9:32 AM, Lars Francke <lars.fran...@gmail.com >>>> > >wrote: >>>> > >>>> > > Hi, >>>> > > >>>> > > I have submitted a couple of minor JIRAs with patches but nothing has >>>> > > happened for months. I'd like to get these in if possible. >>>> > > >>>> > > Is there anything I can do to help that process? >>>> > > >>>> > > <https://issues.apache.org/jira/browse/HIVE-5652> >>>> > > <https://issues.apache.org/jira/browse/HIVE-6331> >>>> > > <https://issues.apache.org/jira/browse/HIVE-6510> >>>> > > >>>> > > Thanks for your help. >>>> > > >>>> > > Cheers, >>>> > > Lars >>>> > > >>>> > >>>> >>> >>> >>> >>> -- >>> Swarnim >>> >> >> >> >> -- >> Swarnim
