[
https://issues.apache.org/jira/browse/HIVE-6931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985936#comment-13985936
]
Sushanth Sowmyan commented on HIVE-6931:
----------------------------------------
Looks good to me. About the only nitpick I have is that it feels wrong to call
WindowsPathUtil.getHdfsUriString (after moving the function to WindowsPathUtil)
from QTestUtil from a section of code that's not specific to windows. From the
actual code, it's perfectly fine, since the function only modifies the uri if
it detects it's in windows, but it reads as if we get the windows version of
hdfs uri from code. That said, my issue is not really with this change as much
as code readability in general, and this is helping remove redundant code and
packaging it in the relevant place, it's merely that it reads funnily.
Eventually, I would like us to move WindowsPathUtil into PathUtil or somesuch.
+1.
> Windows unit test fixes
> -----------------------
>
> Key: HIVE-6931
> URL: https://issues.apache.org/jira/browse/HIVE-6931
> Project: Hive
> Issue Type: Bug
> Components: Tests, Windows
> Reporter: Jason Dere
> Assignee: Jason Dere
> Attachments: HIVE-6931.1.patch, HIVE-6931.1.patch
>
>
> A few misc fixes for some of the unit tests on Windows.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
