----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11925/ -----------------------------------------------------------
(Updated May 6, 2014, 10:06 p.m.) Review request for hive, Ashutosh Chauhan and Jakob Homan. Changes ------- New patch that addressed Carl's review comments. This patch addressed the following missing functions. 1. Create AVRO table from using HIVE schema ( w/o specifying Avro Schema). 2. Copy AVRO table structure and data from existing non-AVRO table using CTAS. 3. Copy AVRO table structure and data from existing AVRO table using CTAS. Note: We can close dependent JIRA HIVE-5803 that is no longer required. Another JIRA has already taken care of this. Bugs: HIVE-3159 https://issues.apache.org/jira/browse/HIVE-3159 Repository: hive-git Description ------- Problem: Hive doesn't support to create a Avro-based table using HQL create table command. It currently requires to specify Avro schema literal or schema file name. For multiple cases, it is very inconvenient for user. Some of the un-supported use cases: 1. Create table ... <Avro-SERDE etc.> as SELECT ... from <NON-AVRO FILE> 2. Create table ... <Avro-SERDE etc.> as SELECT from <AVRO TABLE> 3. Create table without specifying Avro schema. Diffs (updated) ----- ql/src/test/queries/clientpositive/avro_create_as_select.q PRE-CREATION ql/src/test/queries/clientpositive/avro_nested_complex.q PRE-CREATION ql/src/test/queries/clientpositive/avro_nullable_fields.q f90ceb9 ql/src/test/queries/clientpositive/avro_without_schema.q PRE-CREATION ql/src/test/results/clientpositive/avro_create_as_select.q.out PRE-CREATION ql/src/test/results/clientpositive/avro_nested_complex.q.out PRE-CREATION ql/src/test/results/clientpositive/avro_nullable_fields.q.out 77a6a2e ql/src/test/results/clientpositive/avro_without_schema.q.out PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java 9d58d13 serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java PRE-CREATION serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerdeUtils.java 67d5570 serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java PRE-CREATION Diff: https://reviews.apache.org/r/11925/diff/ Testing ------- Wrote a new java Test class for a new Java class. Added a new test case into existing java test class. In addition, there are 4 .q file for testing multiple use-cases. Thanks, Mohammad Islam