----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20899/#review42416 -----------------------------------------------------------
Mostly looks good, some comments. ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java <https://reviews.apache.org/r/20899/#comment76184> Is it necessary to remove final? ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java <https://reviews.apache.org/r/20899/#comment76183> Is it necessary to remove final on these? - Szehon Ho On April 30, 2014, 5:22 p.m., justin coffey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20899/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 5:22 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > - Fix for bug in createArray() that strips null elements. > - In the process refactored serde for simplification purposes. > - Refactored tests for better regression testing. > > > Diffs > ----- > > data/files/parquet_create.txt ccd48ee > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java > b689336 > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java > be518b9 > > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetHiveSerDe.java > PRE-CREATION > ql/src/test/queries/clientpositive/parquet_create.q 0b976bd > ql/src/test/results/clientpositive/parquet_create.q.out 3220be5 > > Diff: https://reviews.apache.org/r/20899/diff/ > > > Testing > ------- > > > Thanks, > > justin coffey > >
