----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/#review43810 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/common/FileUtils.java <https://reviews.apache.org/r/21846/#comment78102> Should check the return flag on the rename to ensure that the rename was successful. If not bail out/log warning as appropriate. common/src/java/org/apache/hadoop/hive/common/FileUtils.java <https://reviews.apache.org/r/21846/#comment78103> Similar comment here. Check that the return type is true to ensure that renaming happened. common/src/java/org/apache/hadoop/hive/common/FileUtils.java <https://reviews.apache.org/r/21846/#comment78101> Does this have to be logged at an info level? Or a debug be more appropriate here? common/src/java/org/apache/hadoop/hive/common/FileUtils.java <https://reviews.apache.org/r/21846/#comment78100> Any specific reason why this exception is not allowed to propagate? - Swarnim Kulkarni On May 23, 2014, 4:42 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21846/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 4:42 a.m.) > > > Review request for hive and Szehon Ho. > > > Repository: hive-git > > > Description > ------- > > HIVE-7117: Partitions not inheriting table permissions after alter rename > partition > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java > ee61350ab1d32db96a234f6444836f76e23f3251 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestFolderPermissions.java > 4f566d2a2999eecea7018836505208ae80662e97 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 221b01043b3520211643847c00b17b328ad2b9c0 > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java > c1790b427e7fa64780fdf0a580f28135d6a4ff8d > > Diff: https://reviews.apache.org/r/21846/diff/ > > > Testing > ------- > > Tested with itests. > > > Thanks, > > Ashish Singh > >
