----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15855/#review43888 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/15855/#comment78174> Technically, its a post event since event = ObjectStore call already happened on previous line. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/15855/#comment78172> Technically, its a post event since event = ObjectStore call already happened on previous line. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/15855/#comment78173> Same comment as previous. ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationPreEventListener.java <https://reviews.apache.org/r/15855/#comment78175> This is expensive. We already made one call on mysql to retrieve all names, now we are gonna make n calls again to get constructed Database object. Better way is to retrieve all constructed Database Objects in one mysql call. Though, this is performance optimization, so I am ok to do it later. ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationPreEventListener.java <https://reviews.apache.org/r/15855/#comment78170> If user is not authorized for show databases, than authorization exception should be thrown instead of not showing that database. ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationPreEventListener.java <https://reviews.apache.org/r/15855/#comment78176> Same comment as previous. ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationPreEventListener.java <https://reviews.apache.org/r/15855/#comment78171> Same comment as previous. - Ashutosh Chauhan On Nov. 26, 2013, 8:49 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15855/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2013, 8:49 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5890 > https://issues.apache.org/jira/browse/HIVE-5890 > > > Repository: hive-git > > > Description > ------- > > Commands like "show database" are not checked in metastore event listener. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 01c2626 > > metastore/src/java/org/apache/hadoop/hive/metastore/events/PreEventContext.java > 5021a73 > > metastore/src/java/org/apache/hadoop/hive/metastore/events/PreGetDatabasesEvent.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/events/PreGetTablesEvent.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/AuthorizationPreEventListener.java > 9a90549 > > Diff: https://reviews.apache.org/r/15855/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
