[ 
https://issues.apache.org/jira/browse/HIVE-7123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010127#comment-14010127
 ] 

Brock Noland commented on HIVE-7123:
------------------------------------

LGTM. The only item is that precisionToBytes is a constant and thus should be 
final and all caps.

> Follow-up of HIVE-6367
> ----------------------
>
>                 Key: HIVE-7123
>                 URL: https://issues.apache.org/jira/browse/HIVE-7123
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.14.0
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>         Attachments: HIVE-7123.1.patch, HIVE-7123.2.patch, HIVE-7123.patch
>
>
> HIVE-6367 provides initial decimal support in Parquet serde. The are a few 
> minor items left over:
> 1. parquet_decimal.q seems failing
> 2. will use fixed length binary to encode decimal instead of variable length 
> binary.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to